Update FormatType in C++ #2596
Merged
Update FormatType in C++ #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Jul 31, 2024
| void traceRecv(const Ice::InputStream&, const Ice::LoggerPtr&, const TraceLevelsPtr&); | ||
| void trace(const char*, const Ice::OutputStream&, const Ice::LoggerPtr&, const TraceLevelsPtr&); |
| @@ -66,11 +66,4 @@ class SliceInfo | |||
| public $isLastSlice; | |||
| } | |||
|
|
|||
| class FormatType | |||
There was a problem hiding this comment.
Removed because unused.
| @@ -607,7 +607,7 @@ Slice::opFormatTypeToString(const OperationPtr& op) | |||
| switch (op->format()) | |||
| { | |||
| case DefaultFormat: | |||
| return "::Ice::FormatType::DefaultFormat"; | |||
| return "::std::nullopt"; | |||
There was a problem hiding this comment.
In the slice2xxx compilers, FormatType has still 3 values that correspond to the metadata.
pepone
approved these changes
Aug 1, 2024
| _encoding = encoding; | ||
|
|
||
| _format = _instance->defaultsAndOverrides()->defaultFormat; | ||
| _format = instance->defaultsAndOverrides()->defaultFormat; |
There was a problem hiding this comment.
Shouldn't this be a second constructor? it is not clear why we use a initialize method.
There was a problem hiding this comment.
I will clean this up in a follow-up PR.
initialize is used by the IceDB template code, but I think we can remove it.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the DefaultFormat enumerator in C++. It also removes _instance from OutputStream in C++.
It's a partial C++ equivalent of #2594.