Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optional mapping in Ruby #2566

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

bernardnormier
Copy link
Member

This PR replaces Ice::Unset in Ruby by simply nil. It keeps the Ice::Unset constant = nil for backwards compatibility.

This PR also removes the ability to pass a nil struct (where nil struct meant a default-constructed struct). Doing so is now an error.

@bernardnormier bernardnormier requested review from pepone and externl July 24, 2024 22:00
Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, on a related note I removed Ice.Unset from Python I guess it would be better to do like in this PR and keep it as an alias to None.

Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The CI failures seem unrelated.

@bernardnormier bernardnormier merged commit bcdd6a4 into zeroc-ice:main Jul 25, 2024
18 checks passed
@bernardnormier bernardnormier deleted the ruby-nil branch December 9, 2024 17:08
InsertCreativityHere pushed a commit to InsertCreativityHere/compiler-comparison that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants