Update checkedCast in JS/TS #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsertCreativityHere
approved these changes
Jul 24, 2024
js/src/Ice/ObjectPrxExtensions.js
Outdated
Comment on lines
503
to
504
| .catch((ex) => { | ||
| if (ex instanceof FacetNotExistException) { | ||
| r.resolve(null); | ||
| } else { | ||
| r.reject(ex); | ||
| } | ||
| r.reject(ex); |
There was a problem hiding this comment.
Is this still necessary?
My understanding is that Promise::catch is only called for rejected promises anyways.
So this feels alot like a pointless catch(ex) { throw ex; }
There was a problem hiding this comment.
we can write it as:
prx.ice_isA(this.ice_staticId(), ctx).then(
(ret) => r.resolve(ret ? new this(prx) : null),
(ex) => r.reject(ex),
);
There was a problem hiding this comment.
Ah yes, because r is a different promise than the one being returned by the ice_isA operation. I'd missed that before.
There was a problem hiding this comment.
Updated code using Jose's suggestion, except without parenthesis around ret and ex.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2323 in JS/TS.