-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Ice Swift src to use async/await #2534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
force-pushed
the
swift-async-await
branch
from
July 19, 2024 15:01
8cf6d20
to
a5e0ddd
Compare
externl
commented
Jul 19, 2024
externl
commented
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Larger question: what's your plan in terms of sync API for proxies and servants?
- keep sync + async APIs like in other language mappings
- provide only an async API like in IceRPC, and the current sync + async APIs is a temporary step?
externl
force-pushed
the
swift-async-await
branch
from
July 26, 2024 14:08
945cd4a
to
8957fb5
Compare
bernardnormier
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
pepone
approved these changes
Jul 30, 2024
Co-authored-by: Jose <[email protected]>
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes PromiseKit and replaces the Promise based API with async/await. We make use of the Swift/ObjC async interop support as well as the Swift's
withCheckedContinuation
helper function.CI is failing as I have not disabled or ported the tests yet (I have some done locally). Just opening this draft PR for feedback. There's also still some cleanup to be done.
Things of note:
Future cleanup and improvements: