Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Ice.rb #2459

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Simplify Ice.rb #2459

merged 2 commits into from
Jul 11, 2024

Conversation

bernardnormier
Copy link
Member

by moving most of its contents to separate files in Ice/

@bernardnormier bernardnormier requested a review from pepone July 11, 2024 17:34
pepone
pepone approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would consider moving getSliceDir to Ice/Util.rb or Ice/SliceUtil.rb

@bernardnormier
Copy link
Member Author

Looks good. I would consider moving getSliceDir to Ice/Util.rb or Ice/SliceUtil.rb

Fixed. Also moves the struct mix-in to Struct.rb.

@bernardnormier bernardnormier merged commit 0021165 into zeroc-ice:main Jul 11, 2024
6 checks passed
@bernardnormier bernardnormier deleted the ruby-cleanup2 branch December 9, 2024 17:07
InsertCreativityHere pushed a commit to InsertCreativityHere/compiler-comparison that referenced this pull request Jan 1, 2025
@bernardnormier
HEAD:(zeroc-ice/ice@0021165a2e) Simplify Ice.rb (zeroc-ice/ice#2459)
06d1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernardnormier @pepone