Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MATLAB Test Discovery Logic #2386

Conversation

InsertCreativityHere
Copy link
Member

@InsertCreativityHere InsertCreativityHere commented Jul 1, 2024

This nanoscopic PR fixes #2385 by changing 1 letter.

@InsertCreativityHere
Copy link
Member Author

And now CI does indeed show that all 17 tests are running:

 *** [1/17] Running matlab/Slice/escape tests ***
...

@InsertCreativityHere
Copy link
Member Author

Looks like the proxy test is broken.
This was one of the tests which was previously being ignored, so who knows how long it's been broken for...

*** [14/17] Running matlab/Ice/proxy tests ***
...
testing opaque endpoints... Error using Ice.ObjectPrx/ice_ping (line 185)
::Ice::ConnectTimeoutException

Error in AllTests.allTests (line 818)
                p1.ice_encodingVersion(Ice.EncodingVersion(1, 0)).ice_ping();

Error in Client (line 15)
    myClass = AllTests.allTests(helper);

Error in runTest (line 28)
        Client(varargin);

@InsertCreativityHere InsertCreativityHere merged commit 91db528 into zeroc-ice:main Jul 2, 2024
6 checks passed
InsertCreativityHere added a commit to InsertCreativityHere/compiler-comparison that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allTests.py skips Ice/operations in MATLAB
2 participants