Cleanup Java Reference implementation #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Jul 1, 2024
| @@ -395,22 +395,22 @@ public ObjectPrx ice_adapterId(String newAdapterId) { | |||
| newAdapterId = ""; | |||
| } | |||
|
|
|||
| if (newAdapterId.equals(_getReference().getAdapterId())) { | |||
| if (newAdapterId.equals(_reference.getAdapterId())) { | |||
There was a problem hiding this comment.
I don't understandand why you replaced calls to _getReference() by _reference only in some method of this file. Should it be a global replace instead?
There was a problem hiding this comment.
Fixed, and replaced all occurrences.
pepone
requested review from
externl
and removed request for
InsertCreativityHere
bernardnormier
requested review from
InsertCreativityHere
and removed request for
externl
InsertCreativityHere
approved these changes
Jul 1, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2344