Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IceUtil namespace in C++ #2346

Merged
merged 8 commits into from
Jun 26, 2024
Merged

Conversation

bernardnormier
Copy link
Member

This PR removes the IceUtil namespace and the top-level include/IceUtil directory.

The public header in "IceUtil" are now in namespace Ice or IceInternal and in the include/Ice directory.

@bernardnormier bernardnormier requested a review from pepone June 25, 2024 22:21
Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would replace "../../src/IceUtill/" with "../IceUtil/" in cpp/src

cpp/include/Ice/StringConverter.h Outdated Show resolved Hide resolved
cpp/src/Ice/Reference.cpp Outdated Show resolved Hide resolved
@bernardnormier bernardnormier merged commit 7de31c8 into zeroc-ice:main Jun 26, 2024
17 checks passed
@bernardnormier bernardnormier deleted the iceutil branch December 9, 2024 17:09
InsertCreativityHere pushed a commit to InsertCreativityHere/compiler-comparison that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants