Remove C++ SSL Certificate API #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
May 8, 2024
cpp/include/Ice/SSL/Certificate.h
Outdated
There was a problem hiding this comment.
I need to rename this header.
- DistinguishedName can go into an internal header
- Exception would remain public.
bernardnormier
approved these changes
May 8, 2024
| */ | ||
| std::vector<CertificatePtr> certs; | ||
| PCCERT_CONTEXT peerCertificate = nullptr; |
There was a problem hiding this comment.
Public fields is not a common / recommended style in C++.
It's ok for plain struct but not for such a class. It should be instead:
public:
PCCERT_CONTEXT peerCertificate() const noexcept { return _peerCertificate; }
private:
const PCCERT_CONTEXT _peerCertificate = nullptr;There was a problem hiding this comment.
The base class has public fields for other properties, should we fix them in a follow-up PR?
| /** | ||
| * The peer certificate. | ||
| */ | ||
| SecCertificateRef peerCertificate = nullptr; |
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the C++ Certificate API,
IceSSL::ConnectionInfoprovides the native peer certificate, (not a certificate chain).