Rework hashing in C++ #2123
Merged
Rework hashing in C++ #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
May 6, 2024
| { | ||
| int value = Reference::hashInit(); | ||
| hashAdd(value, _adapterId); |
There was a problem hiding this comment.
In a remarkable twist, we were not including endpoints at all in the hash. As a result, all the endpoint hashing was completely unused!
I double checked - this code is identical on 3.7.
pepone
approved these changes
May 7, 2024
| } | ||
|
|
||
| inline void hashAdd(std::int32_t& hashCode, const std::string& value) | ||
| inline void hashAdd(std::size_t& hashCode, const std::vector<EndpointIPtr>& seq) | ||
| { |
There was a problem hiding this comment.
We could add the container's size to the hash, when hashing a collection.
There was a problem hiding this comment.
I'd rather keep the same logic as in C#.
In C#, since we treat null collection = empty collection, and we skip nulls, we can't add the size of the collection to the hash.
externl
approved these changes
May 7, 2024
Merged
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the hashing in C++.
The only public hashing in C++ is for proxies. It is now exposed as a std::hash specialization of Ice::ObjectPrx.
It's used primarily by the C++-based language mappings: Python and Ruby. Strangely, it does not appear to be used by PHP.