Hash cleanup in C# #2120
Merged
Hash cleanup in C# #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
May 6, 2024
Comment on lines
+2907
to
+2908
| _out << nl << "var hash = new global::System.HashCode();"; | ||
| assert(dataMembers.size() > 0); // a Slice struct must have at least one field. |
There was a problem hiding this comment.
This is because we're using the defaults for classes and exceptions.
bernardnormier
commented
May 7, 2024
csharp/src/Ice/Internal/Reference.cs
Outdated
| return hashValue_; | ||
| } | ||
| } | ||
| public override int GetHashCode() => HashCode.Combine(base.GetHashCode(), _adapterId); |
There was a problem hiding this comment.
We should include the endpoints in this hash.
There was a problem hiding this comment.
Fixed. Also added test.
pepone
approved these changes
May 7, 2024
Merged
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the implementation of GetHashCode in C# by using the BCL HashCode. It also removes all hash code caching.