Move C++ SSL transport to Ice core #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Apr 16, 2024
Comment on lines
5
to
6
| #ifndef ICESSL_PLUGIN_H | ||
| #define ICESSL_PLUGIN_H |
There was a problem hiding this comment.
The header guard should probably updated to CERTIFICATE
| class OpenSSLCertificateI : public IceSSL::OpenSSL::Certificate, | ||
| public CertificateI, | ||
| public IceSSL::CertificateExtendedInfo | ||
| class OpenSSLCertificateI : public IceSSL::OpenSSL::Certificate, public CertificateI |
There was a problem hiding this comment.
Suggested change
| class OpenSSLCertificateI : public IceSSL::OpenSSL::Certificate, public CertificateI | |
| class OpenSSLCertificateI : public OpenSSL::Certificate, public CertificateI |
| { | ||
| namespace RFC2253 | ||
| typedef std::list<std::pair<std::string, std::string>> RDNSeq; |
There was a problem hiding this comment.
Suggested change
| typedef std::list<std::pair<std::string, std::string>> RDNSeq; | |
| using RDNSeq = std::list<std::pair<std::string, std::string>>; |
| RDNSeq rdn; | ||
| bool negate; | ||
| }; | ||
| typedef std::list<RDNEntry> RDNEntrySeq; |
There was a problem hiding this comment.
Suggested change
| typedef std::list<RDNEntry> RDNEntrySeq; | |
| using RDNEntrySeq = std::list<RDNEntry>; |
|
I would fix review-comments in a follow-up PR. |
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.