Added comments to connection's implementation #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Apr 16, 2024
| @@ -576,7 +576,7 @@ Ice::ConnectionI::waitUntilFinished() | |||
| // guarantee that there are no outstanding calls when deactivate() | |||
| // is called on the servant locators. | |||
| // | |||
| _conditionVariable.wait(lock, [this] { return _state >= StateFinished && _dispatchCount == 0; }); | |||
| _conditionVariable.wait(lock, [this] { return _state >= StateFinished && _upcallCount == 0; }); | |||
There was a problem hiding this comment.
It's not clear to me why we wait for all upcalls to complete. The comment mentions servant locators but servant locators only care about dispatches. Once we have an actual dispatch count, should we use it here instead of _upcallCount?
There was a problem hiding this comment.
I think it's about providing the guarantee that no more upcalls are running once the communicator destroy method returns.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comments to Connection::message implementation.