Move C++ ssl transport to Ice core #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
reviewed
Apr 11, 2024
cpp/include/IceSSL/IceSSL.h
Outdated
| @@ -5,9 +5,6 @@ | |||
| #ifndef ICESSL_ICESSL_H | |||
| #define ICESSL_ICESSL_H | |||
|
|
|||
| #include "Config.h" | |||
| #include "Plugin.h" | |||
|
|
|||
| #if defined(_WIN32) | |||
There was a problem hiding this comment.
I assume we want to remove the IceSSL include directory entirely once the merger is complete?
There was a problem hiding this comment.
Yes, the remaining public headers:
Certificate.h
ConnectionInfo.h
ConnectionInfoF.h
EndpointInfo.h
OpenSSL.h
SChannel.h
SecureTransport.h
cpp/include/IceSSL/OpenSSL.h
Outdated
| @@ -59,7 +21,7 @@ namespace IceSSL | |||
| * Encapsulates an OpenSSL X.509 certificate. | |||
| * \headerfile IceSSL/IceSSL.h | |||
| */ | |||
| class ICESSL_OPENSSL_API Certificate : public virtual IceSSL::Certificate | |||
| class ICE_API Certificate : public virtual IceSSL::Certificate | |||
There was a problem hiding this comment.
Can we remove the virtual, or do we actually use multiple inheritance with Certificates?
There was a problem hiding this comment.
Yes I think we can. We should first consider if we want to keep them.
The main use case I see now for this class is to inspect the peer certificate in the connection info.
- Remove the random usage in the tests - Adds a test to exercise Ice.ServerIdleTime - Fix a few selector bugs Closes zeroc-ice#2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.