Switch to using swift-format from Apple
#2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Apr 2, 2024
ReeceHumphreys
added a commit
that referenced
this pull request
Apr 2, 2024
This reverts commit 4805aa4.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
…` from Apple (zeroc-ice/ice#2005)" This reverts commit 4805aa49cf63eed60c5b410ba6e88d8504e8c4cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Swift linting and formatting was done with https://github.com/nicklockwood/SwiftFormat. However, I believe we should have been doing it with https://github.com/apple/swift-format which is the official linter and formatter from Apple.
I am using the default configuration for everything besides
AlwaysUseLowerCamelCasewhich I had to set to false due to lots of our variable names.