Ice::Object cleanup #1954
Merged
Ice::Object cleanup #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Mar 16, 2024
|
|
||
| namespace Ice | ||
| { | ||
| /** | ||
| * A mapping from facet name to servant. | ||
| */ | ||
| using FacetMap = ::std::map<::std::string, std::shared_ptr<Object>>; | ||
| using FacetMap = std::map<std::string, ObjectPtr>; |
There was a problem hiding this comment.
should we use std::lesss<> in case we want to lookup with a string_view?
There was a problem hiding this comment.
I guess we could, but I'd rather leave this for another PR. Same question for the more frequently used Context:
// generated code
/**
* A request context. <code>Context</code> is used to transmit metadata about a request from the server to the client,
* such as Quality-of-Service (QoS) parameters. Each operation on the client has a <code>Context</code> as its
* implicit final parameter.
*/
using Context = ::std::map<::std::string, ::std::string>;
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds constructors and assignment operators to Ice::Object (see #1926), moves emptyCurrent to Current.h, improves the implementation of MarshaledResult, and replaces all std::sharedIce::Object (and similar) by Ice::ObjectPtr.