Cleanup slice2cpp metadata #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Feb 27, 2024
bernardnormier
approved these changes
Feb 27, 2024
| @@ -2311,7 +2038,7 @@ Slice::Gen::ProxyVisitor::visitOperation(const OperationPtr& p) | |||
| // | |||
| // Generate a read method if there are more than one ret/out parameter. If there's | |||
| // only one, we rely on the default read method from LambdaOutgoing | |||
| // except if the unique ret/out is optional or is an array/range. | |||
| // except if the unique ret/out is optional or is an array. | |||
There was a problem hiding this comment.
This comment is actually not correct. The array metadata doesn't affect the "promise" mapping.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
…/ice#1867) - Remove cpp::comparable, cpp::scoped, cpp::class, cpp:range. - Remove cpp11:: and cpp98:: top level metadata and issue a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in cleaning up the leftover C++98 code in the
slice2cppcompiler. Its primary goal is removal of the cpp98 metadata from the compiler as well as the Ice Slice files and tests.cpp::comparable,cpp::scoped,cpp::class,cpp:range.cpp11::andcpp98::top level metadata and issue a warning.See #1807