Update createProxy to return a non-optional ObjectPrx #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Feb 20, 2024
cpp/src/Ice/ConnectionI.cpp
Outdated
| Ice::ConnectionI::createProxy(const Identity& ident) const | ||
| { | ||
| // TODO: merge my other PR code | ||
|
|
||
| // Create a reference and return a reverse proxy for this reference. | ||
| ReferencePtr ref = | ||
| _instance->referenceFactory()->create(ident, const_cast<ConnectionI*>(this)->shared_from_this()); | ||
|
|
There was a problem hiding this comment.
Should we assert "ref" is not null? does the reference factory ever return null from create?
There was a problem hiding this comment.
That's a good question. And no, ref can never but null, and I added a few asserts in ReferenceFactory to make sure the identity's name it gets is never empty.
externl
approved these changes
Feb 20, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates createProxy/createDirectoryProxy/createIndirectProxy to return a non-nullable proxy in C++.