Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify OutputStream constructor #2595

Closed
6 tasks done
bernardnormier opened this issue Jul 31, 2024 · 3 comments
Closed
6 tasks done

Simplify OutputStream constructor #2595

bernardnormier opened this issue Jul 31, 2024 · 3 comments
Labels
cleanup task
Milestone
3.8.0

Comments

@bernardnormier
Copy link
Member

bernardnormier commented Jul 31, 2024 •
edited by pepone
Loading

We have too many OutputStream constructors. And OutputStream should not hold onto instance.

To fix in:

  • C++
  • C#
  • Java
  • JavaScript
  • MATLAB
  • Swift

C#: see #2594
@bernardnormier bernardnormier added this to the 3.8.0 milestone Jul 31, 2024
@bernardnormier
Copy link
Member Author

C++: #2609

@bernardnormier
Copy link
Member Author

JavaScript, MATLAB, Swift: #2618

@pepone pepone mentioned this issue Sep 30, 2024
Closed
pepone added a commit to pepone/ice that referenced this issue Oct 1, 2024
@pepone
Simplify OutputStream constructor in Java - See zeroc-ice#2595
85020fd
@pepone pepone mentioned this issue Oct 1, 2024
Merged
pepone added a commit to pepone/ice that referenced this issue Oct 1, 2024
@pepone
Simplify OutputStream constructor in Java - See zeroc-ice#2595
6d845de
pepone added a commit to pepone/ice that referenced this issue Oct 2, 2024
@pepone
Revert "Simplify OutputStream constructor in Java - See zeroc-ice#2595"
c9f2b1e 
This reverts commit 6d845de.
@pepone
Copy link
Member

pepone commented Oct 3, 2024

Java fixed in b9a1036

@pepone pepone closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup task
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
2 participants
@pepone @bernardnormier