IceGridGUI can't connect to IceGrid via Glacier2 (main)

[bernardnormier]

Such a connection attempt hangs forever when using the "IceGrid/admin" test registry + router.

[pepone]

From my tests what I see is that the registration of the observers timeouts in

ice/java/src/IceGridGUI/src/main/java/com/zeroc/IceGridGUI/SessionKeeper.java

Line 4675 in 4d832c8

session.registerObservers();

After this calls fails, the handling of TimeoutException hangs calling _communicator.destroy

"AWT-EventQueue-0" #22 [25107] prio=6 os_prio=31 cpu=880.27ms elapsed=369.69s tid=0x000000011c926200 nid=25107 in Object.wait()  [0x000000017446e000]
   java.lang.Thread.State: WAITING (on object monitor)
	at java.lang.Object.wait0([email protected]/Native Method)
	- waiting on <no object reference available>
	at java.lang.Object.wait([email protected]/Object.java:366)
	at java.lang.Object.wait([email protected]/Object.java:339)
	at com.zeroc.Ice.ConnectionI.waitUntilFinished(ConnectionI.java:241)
	- locked <0x000000061f727248> (a com.zeroc.Ice.ConnectionI)
	at com.zeroc.Ice.OutgoingConnectionFactory.waitUntilFinished(OutgoingConnectionFactory.java:88)
	at com.zeroc.Ice.Instance.destroy(Instance.java:1168)
	at com.zeroc.Ice.Communicator.destroy(Communicator.java:41)
	at com.zeroc.IceGridGUI.Coordinator.destroyCommunicator(Coordinator.java:3074)
	at com.zeroc.IceGridGUI.Coordinator.setConnected(Coordinator.java:3216)
	at com.zeroc.IceGridGUI.SessionKeeper$Session.close(SessionKeeper.java:264)
	at com.zeroc.IceGridGUI.SessionKeeper$Session.logout(SessionKeeper.java:174)
	at com.zeroc.IceGridGUI.SessionKeeper.logout(SessionKeeper.java:4973)
	at com.zeroc.IceGridGUI.SessionKeeper.lambda$loginSuccess$1(SessionKeeper.java:4696)
	at com.zeroc.IceGridGUI.SessionKeeper$$Lambda/0x00000070012a3a68.run(Unknown Source)
	at java.awt.event.InvocationEvent.dispatch([email protected]/InvocationEvent.java:308)

[pepone]

Wonder if this is related to #2595 and the workaround added here:

ice/java/src/Ice/src/main/java/com/zeroc/Ice/ConnectionI.java

Line 2254 in 4d832c8

System.err.println(

If my suspicious is correct the upCall for this requests is never decremented, and this will cause the connection waitUntilFinished call to wait for ever.

[pepone]

The registration of the observers was failing due to #2826, and the communicator destroy hang because #2595 was not yet fixed.

Both issues are now fixed.