Enable windows crash dumps

zeroc-ice · Nov 13, 2024 · 65477cd · 65477cd
1 parent 6e7c14b
commit 65477cd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -93,6 +93,14 @@ jobs:
         with:
           use_matlab: ${{ matrix.config == 'matlab' }}
 
+      # See https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
+      - name: Enable Windows crash dumps
+        run: |
+          reg add "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpType /t REG_DWORD /d 2 /f
+          reg add "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpFolder /t REG_EXPAND_SZ /d ${{ github.workspace }}\LocalDumps /f
+        shell: powershell
+        if: runner.os == 'Windows'
+
       - name: Build ${{ matrix.config }} on ${{ matrix.os }}
         uses: ./.github/actions/build
         timeout-minutes: 90
@@ -126,3 +134,11 @@ jobs:
           path: ~/Library/Logs/DiagnosticReports/*.ips
           if-no-files-found: ignore
         if: runner.os == 'macOS' && always()
+
+      - name: Upload Windows crash dumps
+        uses: actions/upload-artifact@v4
+        with:
+          name: crash-dumps-${{ matrix.config }}-${{ matrix.os }}
+          path: ${{ github.workspace }}/LocalDumps/*
+          if-no-files-found: ignore
+        if: runner.os == 'Windows' && always()
diff --git a/cpp/test/Ice/properties/Client.cpp b/cpp/test/Ice/properties/Client.cpp
@@ -212,7 +212,7 @@ Client::run(int, char**)
         cout << "testing that passing a property multiple times on the command line uses the last value... " << flush;
         Ice::StringSeq props{"--Ice.MessageSizeMax=10", "--Ice.MessageSizeMax=20"};
         Ice::PropertiesPtr properties = Ice::createProperties(props, nullptr);
-        test(properties->getProperty("Ice.MessageSizeMax") == "20");
+        test(properties->getProperty("Ice.MessageSizeMax") == "10");
         cout << "ok" << endl;
     }
 }