Skip to content

Commit

Permalink
No need to destroy endpoint factories in JavaScript
Browse files Browse the repository at this point in the history
  • Loading branch information
pepone committed Oct 28, 2024
1 parent ffaef5e commit 2f7a83b
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 17 deletions.
5 changes: 0 additions & 5 deletions js/src/Ice/EndpointFactoryManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,4 @@ export class EndpointFactoryManager {
s.endEncapsulation();
return e;
}

destroy() {
this._factories.forEach(factory => factory.destroy());
this._factories = [];
}
}
3 changes: 0 additions & 3 deletions js/src/Ice/InstanceExtensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,6 @@ Instance.prototype.destroy = async function () {
if (this._locatorManager) {
this._locatorManager.destroy();
}
if (this._endpointFactoryManager) {
this._endpointFactoryManager.destroy();
}

if (this._initData.properties.getPropertyAsInt("Ice.Warn.UnusedProperties") > 0) {
const unusedProperties = this._initData.properties.getUnusedProperties();
Expand Down
4 changes: 0 additions & 4 deletions js/src/Ice/TcpEndpointFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ export class TcpEndpointFactory {
return e;
}

destroy() {
this._instance = null;
}

clone(instance) {
return new TcpEndpointFactory(instance);
}
Expand Down
5 changes: 0 additions & 5 deletions js/src/Ice/WSEndpointFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,4 @@ export class WSEndpointFactory {
e.initWithStream(s);
return e;
}

destroy() {
this._delegate.destroy();
this._instance = null;
}
}

0 comments on commit 2f7a83b

Please sign in to comment.