more fixes

zeroc-ice · Dec 18, 2024 · 2babad0 · 2babad0
1 parent 3276e51
commit 2babad0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/cpp/src/Ice/SSL/SchannelTransceiverI.h b/cpp/src/Ice/SSL/SchannelTransceiverI.h
@@ -52,13 +52,13 @@ namespace Ice::SSL::Schannel
         void setBufferSize(int rcvSize, int sndSize) final;
 
     private:
-        IceInternal::SocketOperation sslHandshake(SecBuffer* initialBuffer = nullptr);
+        [[nodiscard]] IceInternal::SocketOperation sslHandshake(SecBuffer* initialBuffer = nullptr);
 
-        size_t decryptMessage(IceInternal::Buffer&);
-        size_t encryptMessage(IceInternal::Buffer&);
+        [[nodiscard]] size_t decryptMessage(IceInternal::Buffer&);
+        [[nodiscard]] size_t encryptMessage(IceInternal::Buffer&);
 
-        bool writeRaw(IceInternal::Buffer&);
-        bool readRaw(IceInternal::Buffer&);
+        [[nodiscard]] bool writeRaw(IceInternal::Buffer&);
+        [[nodiscard]] bool readRaw(IceInternal::Buffer&);
 
         enum State
         {

diff --git a/cpp/src/Ice/SSL/SecureTransportTransceiverI.h b/cpp/src/Ice/SSL/SecureTransportTransceiverI.h
@@ -36,13 +36,14 @@ namespace Ice::SSL::SecureTransport
             const std::string&,
             const Ice::SSL::ClientAuthenticationOptions&);
         ~TransceiverI();
-        IceInternal::NativeInfoPtr getNativeInfo() final;
 
-        IceInternal::SocketOperation initialize(IceInternal::Buffer&, IceInternal::Buffer&) final;
-        IceInternal::SocketOperation closing(bool, std::exception_ptr) final;
+        [[nodiscard]] IceInternal::NativeInfoPtr getNativeInfo() final;
+
+        [[nodiscard]] IceInternal::SocketOperation initialize(IceInternal::Buffer&, IceInternal::Buffer&) final;
+        [[nodiscard]] IceInternal::SocketOperation closing(bool, std::exception_ptr) final;
         void close() final;
-        IceInternal::SocketOperation write(IceInternal::Buffer&) final;
-        IceInternal::SocketOperation read(IceInternal::Buffer&) final;
+        [[nodiscard]] IceInternal::SocketOperation write(IceInternal::Buffer&) final;
+        [[nodiscard]] IceInternal::SocketOperation read(IceInternal::Buffer&) final;
 
         [[nodiscard]] std::string protocol() const final;
         [[nodiscard]] std::string toString() const final;