Register all owned wallets on initialize #631
Open
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at Oct 18, 1:34:43 AM UTC] |
zerts
reviewed
Oct 15, 2024
| params: { address, origin }, | ||
| }); | ||
| } catch (error) { | ||
| console.log('registerWallet error', error); // eslint-disable-line no-console |
There was a problem hiding this comment.
As I see, we will try register each wallet only once. So if something goes wrong, we will not try again.
May be we should not mark register process as complete in this case and try again next time?
There was a problem hiding this comment.
I'll update it to not set the flag if at least one wallet fails to register
edit: updated ✅
zerts
approved these changes
Oct 15, 2024
| }); | ||
| } catch (error) { | ||
| didFail = true; | ||
| console.log('registerWallet error', error); // eslint-disable-line no-console |
There was a problem hiding this comment.
updated to console.warn ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.