soc: ambiq: Add support for ambiq apollo510 soc #88737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_ambiq
DNM (manifest)
There was a problem hiding this comment.
Copilot reviewed 25 out of 36 changed files in this pull request and generated no comments.
Files not reviewed (11)
- boards/ambiq/apollo510_evb/CMakeLists.txt: Language not supported
- boards/ambiq/apollo510_evb/Kconfig: Language not supported
- boards/ambiq/apollo510_evb/Kconfig.apollo510_evb: Language not supported
- boards/ambiq/apollo510_evb/Kconfig.defconfig: Language not supported
- boards/ambiq/apollo510_evb/apollo510_evb-pinctrl.dtsi: Language not supported
- boards/ambiq/apollo510_evb/apollo510_evb.dts: Language not supported
- boards/ambiq/apollo510_evb/apollo510_evb_defconfig: Language not supported
- boards/ambiq/apollo510_evb/board.cmake: Language not supported
- boards/ambiq/apollo510_evb/doc/index.rst: Language not supported
- drivers/pinctrl/Kconfig.ambiq: Language not supported
- dts/arm/ambiq/ambiq_apollo510.dtsi: Language not supported
Comments suppressed due to low confidence (2)
drivers/timer/ambiq_stimer.c:218
- For CONFIG_SOC_SERIES_APOLLO5X, the call to am_hal_stimer_config omits enabling COMPARE_B. Please verify that this change is intentional and that the hardware does not require the COMPARE_B configuration.
am_hal_stimer_config((oldCfg & ~(AM_HAL_STIMER_CFG_FREEZE | STIMER_STCFG_CLKSEL_Msk)) | TIMER_CLKSRC | AM_HAL_STIMER_CFG_COMPARE_A_ENABLE);
drivers/pinctrl/pinctrl_ambiq.c:62
- The default case in the new switch on 'pin->sdif_cdwp' simply breaks without any handling. Consider logging or explicitly handling unexpected values to clarify intent.
default:
AlessandroLuo
force-pushed
the
apollo510-base-ver
branch
2 times, most recently
from
808630d to
3b157f6
Compare
github-actions
bot
removed
the
DNM (manifest)
There was a problem hiding this comment.
Copilot reviewed 25 out of 36 changed files in this pull request and generated no comments.
Files not reviewed (11)
- boards/ambiq/apollo510_evb/CMakeLists.txt: Language not supported
- boards/ambiq/apollo510_evb/Kconfig: Language not supported
- boards/ambiq/apollo510_evb/Kconfig.apollo510_evb: Language not supported
- boards/ambiq/apollo510_evb/Kconfig.defconfig: Language not supported
- boards/ambiq/apollo510_evb/apollo510_evb-pinctrl.dtsi: Language not supported
- boards/ambiq/apollo510_evb/apollo510_evb.dts: Language not supported
- boards/ambiq/apollo510_evb/apollo510_evb_defconfig: Language not supported
- boards/ambiq/apollo510_evb/board.cmake: Language not supported
- boards/ambiq/apollo510_evb/doc/index.rst: Language not supported
- drivers/pinctrl/Kconfig.ambiq: Language not supported
- dts/arm/ambiq/ambiq_apollo510.dtsi: Language not supported
Comments suppressed due to low confidence (2)
drivers/timer/ambiq_stimer.c:36
- [nitpick] Consider clarifying in the surrounding comment why the backup comparator is omitted for Apollo5x configurations to improve code readability.
#if defined(CONFIG_SOC_SERIES_APOLLO5X)
drivers/gpio/gpio_ambiq.c:583
- [nitpick] Consider adding an inline comment to explain why the offset is shifted right by 2 for non-Apollo3x configurations.
pin += (dev_cfg->offset >> 2);
e341193 to
9e93f4d
Compare
github-actions
bot
added
the
DNM (manifest)
AlessandroLuo
force-pushed
the
apollo510-base-ver
branch
from
9e93f4d to
e146887
Compare
github-actions
bot
removed
the
DNM (manifest)
AlessandroLuo
force-pushed
the
apollo510-base-ver
branch
2 times, most recently
from
b9eb8d5 to
6641ec9
Compare
github-actions
bot
added
area: Timer
github-actions
bot
requested review from
aaronyegx,
andyross,
dcpleung and
gmarull
github-actions
bot
requested review from
henrikbrixandersen,
katsuster,
martinjaeger,
mnkp,
RichardSWheatley and
teburd
aaronyegx
reviewed
Apr 18, 2025
swift-tk
requested changes
Apr 18, 2025
AlessandroLuo
force-pushed
the
apollo510-base-ver
branch
from
6641ec9 to
d38f328
Compare
Add all required parts (new SoC family/series, device tree) for the Ambiq Apollo510 SoC. Signed-off-by: Hao Luo <[email protected]>
This commit adds support for the Ambiq Apollo510 Evaluation Board. Signed-off-by: Hao Luo <[email protected]>
This commit adds pinctrl support for Apollo510 SoCs, and unified pinctrl bindings across apollo families. Signed-off-by: Hao Luo <[email protected]>
Added more clock sources for Apollo510 support Signed-off-by: Hao Luo <[email protected]>
This commit adds support for Apollo510 SoC in ambiq stimer driver Signed-off-by: Hao Luo <[email protected]>
This commit adds support for Apollo510 SoC in ambiq gpio driver Signed-off-by: Hao Luo <[email protected]>
This commit adds support for Apollo510 SoC in ambiq wdt driver Signed-off-by: Hao Luo <[email protected]>
AlessandroLuo
force-pushed
the
apollo510-base-ver
branch
from
d38f328 to
07de32b
Compare
swift-tk
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces board support for the Apollo510 SOC while updating several drivers and device tree bindings to accommodate Apollo5x series hardware changes. Key changes include the addition of a new GPIO header and function, updates to timer and serial drivers for Apollo5x compatibility, and new board definitions and device tree bindings.