Skip to content

doc: sbom cmd more detail for build_dir #88721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

doc: sbom cmd more detail for build_dir #88721

merged 1 commit into from
May 5, 2025

Conversation

tobiwan88
Copy link
Contributor

@tobiwan88 tobiwan88 commented Apr 16, 2025 •
edited by kartben
Loading

when following the example it was not clear that BUILD_DIR needs to point to application for sysbuild builds.

@github-actions GitHub Actions
Copy link

Hello @tobiwan88, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@tobiwan88 tobiwan88 force-pushed the docu_sbom_more_info branch 2 times, most recently from fee1665 to 519197e Compare April 17, 2025 17:32
@tobiwan88
Copy link
Contributor Author

I fixed the email address in the commit from my work email to my privated (linked as primary mail for github)

@tobiwan88
Copy link
Contributor Author

ping @kartben @carlescufi

@tobiwan88 @kartben
doc: sbom cmd more detail for build_dir
d0f32aa 
when following the example it was not clear that BUILD_DIR needs to point
to application for sysbuild builds

Signed-off-by: Tobias Meyer <[email protected]>
@kartben kartben force-pushed the docu_sbom_more_info branch from 519197e to d0f32aa Compare May 5, 2025 12:33
@kartben
Copy link
Collaborator

kartben commented May 5, 2025

ping @kartben @carlescufi

Sorry for the delay. Thanks for the PR! I've just pushed minor formatting tweaks as the indentation was incorrect

@kartben kartben merged commit 64fe434 into zephyrproject-rtos:main May 5, 2025
22 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025

Hi @tobiwan88!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@kartben
Copy link
Collaborator

kartben commented May 5, 2025

@tobiwan88 I can't believe this is only your first PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@pdgendt pdgendt pdgendt approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@nashif nashif Awaiting requested review from nashif

@swinslow swinslow Awaiting requested review from swinslow

Assignees

@kartben kartben

@carlescufi carlescufi

Labels
area: Documentation area: West West utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiwan88 @kartben @pdgendt @carlescufi