Skip to content

drivers: stm32_hal: stm32_rng Fix compile errors for stm32l4 rng. #88719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

mihnen
Copy link
Contributor

@mihnen mihnen commented Apr 16, 2025

The low level function names in the stm32l4xx low level driver are different than all the other stm32's even though the functionality is the same. This breaks the entropy module for these parts. This patch fixes the build and has been tested on a custom stm32l4p5 board.

Fixes: #88621

Copy link

Hello @mihnen, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting a few changes to the commit message:

-drivers: stm32_hal: stm32_rng Fix compile errors for stm32l4 rng.
+drivers: entropy: stm32: fix compile errors for STM32L4 series

The low level function names in the stm32l4xx low level driver are
different than all the other stm32's even though the functionality is the
same. This breaks the entropy module for these parts. This patch fixes the
build and has been tested on a custom stm32l4p5 board.

+This STM32CubeL4 issue has been reported (ST Internal Reference: 207828).

Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/88621

Signed-off-by: Matt Ihnen <[email protected]>

(git commit --amend to edit the message + force push should avoid a new run of CI)

@mihnen mihnen force-pushed the fix-stm32l4-rng-entropy branch from 02c1278 to 9b7c5d6 Compare April 16, 2025 14:52
@mihnen mihnen requested a review from mathieuchopstm April 16, 2025 15:48
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo remaining in commit message 😅 (Interval -> Internal)

- This STM32CubeL4 issue has been reported (ST Interval Reference: 207828).
+ This STM32CubeL4 issue has been reported (ST Internal Reference: 207828).

The low level function names in the stm32l4xx low level driver are
different than all the other stm32's even though the functionality is the
same. This breaks the entropy module for these parts. This patch fixes the
build and has been tested on a custom stm32l4p5 board.

This STM32CubeL4 issue has been reported (ST Internal Reference: 207828).

Fixes: zephyrproject-rtos#88621

Signed-off-by: Matt Ihnen <[email protected]>
@mihnen mihnen force-pushed the fix-stm32l4-rng-entropy branch from 9b7c5d6 to 5466971 Compare April 16, 2025 16:52
@mihnen mihnen requested a review from mathieuchopstm April 16, 2025 16:53
@kartben kartben merged commit 132289e into zephyrproject-rtos:main Apr 22, 2025
24 checks passed
Copy link

Hi @mihnen!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32L4x rng entropy driver fails to compile
5 participants