-
Notifications
You must be signed in to change notification settings - Fork 7.4k
drivers: stm32_hal: stm32_rng Fix compile errors for stm32l4 rng. #88719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: stm32_hal: stm32_rng Fix compile errors for stm32l4 rng. #88719
Conversation
Hello @mihnen, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just requesting a few changes to the commit message:
-drivers: stm32_hal: stm32_rng Fix compile errors for stm32l4 rng.
+drivers: entropy: stm32: fix compile errors for STM32L4 series
The low level function names in the stm32l4xx low level driver are
different than all the other stm32's even though the functionality is the
same. This breaks the entropy module for these parts. This patch fixes the
build and has been tested on a custom stm32l4p5 board.
+This STM32CubeL4 issue has been reported (ST Internal Reference: 207828).
Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/88621
Signed-off-by: Matt Ihnen <[email protected]>
(git commit --amend
to edit the message + force push should avoid a new run of CI)
02c1278
to
9b7c5d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo remaining in commit message 😅 (Interval -> Internal)
- This STM32CubeL4 issue has been reported (ST Interval Reference: 207828).
+ This STM32CubeL4 issue has been reported (ST Internal Reference: 207828).
The low level function names in the stm32l4xx low level driver are different than all the other stm32's even though the functionality is the same. This breaks the entropy module for these parts. This patch fixes the build and has been tested on a custom stm32l4p5 board. This STM32CubeL4 issue has been reported (ST Internal Reference: 207828). Fixes: zephyrproject-rtos#88621 Signed-off-by: Matt Ihnen <[email protected]>
9b7c5d6
to
5466971
Compare
Hi @mihnen! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
The low level function names in the stm32l4xx low level driver are different than all the other stm32's even though the functionality is the same. This breaks the entropy module for these parts. This patch fixes the build and has been tested on a custom stm32l4p5 board.
Fixes: #88621