Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: zms: fix dropped messages #86281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

samples: zms: fix dropped messages #86281

wants to merge 1 commit into from
+1 −0

Conversation

butok
Copy link
Contributor

@butok butok commented Feb 25, 2025

  • Sets CONFIG_LOG_MODE_IMMEDIATE for the zms sample.
  • Fixes "--- 9999 messages dropped ---".

@butok
samples: zms: fix dropped messages
7934f18 
- Sets CONFIG_LOG_MODE_IMMEDIATE for the zms sample.
- Fixes "--- 9999 messages dropped ---".

Signed-off-by: Andrej Butok <[email protected]>
@zephyrbot zephyrbot added area: Samples Samples size: XS A PR changing only a single line of code area: File System labels Feb 25, 2025
carlescufi
carlescufi reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make the log buffer larger instead?

@butok
Copy link
Contributor Author

butok commented Feb 25, 2025

Why not make the log buffer larger instead?

To use the same approach (CONFIG_LOG_MODE_IMMEDIATE) as the NVS sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi carlescufi left review comments

@rghaddab rghaddab rghaddab approved these changes

@de-nordic de-nordic Awaiting requested review from de-nordic

@kartben kartben Awaiting requested review from kartben

@Laczen Laczen Awaiting requested review from Laczen

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

At least 2 approving reviews are required to merge this pull request.

Assignees

@de-nordic de-nordic

Labels
area: File System area: Samples Samples size: XS A PR changing only a single line of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@butok @carlescufi @rghaddab @zephyrbot @de-nordic