nRF SAADC Add PM device runtime support #85495
Merged
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
changed the title
zephyrbot
added
area: ADC
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
gmarull
reviewed
Feb 14, 2025
drivers/adc/adc_nrfx_saadc.c
Outdated
Comment on lines
173
to
181
| static void saadc_pm_suspend(void) | ||
| { | ||
| nrf_saadc_disable(NRF_SAADC); | ||
| } | ||
|
|
||
| static void saadc_pm_resume(void) | ||
| { | ||
| nrf_saadc_enable(NRF_SAADC); | ||
| } |
There was a problem hiding this comment.
I'd really supress these, better call enable/disable where needed
bjarki-andreasen
force-pushed
the
nrf-saadc-add-pm-device
branch
from
37e23a7 to
01d1193
Compare
gmarull
previously approved these changes
Feb 14, 2025
anangl
reviewed
Feb 14, 2025
Extend nrf saadc device driver with pm device runtime support. To preserve previous behavior: * if pm device is disabled, saadc is resumed on sampling start and suspended when sampling done. * if pm device is enabled only, saadc does nothing on sampling start/stop. its resumed on init. * if pm device runtime is enabled, saadc is got on sampling start, and put on sampling stop. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Set pm device runtime runtime auto flag to ensure saadc instances are initialized correctly if pm device runtime is used. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
nrf-saadc-add-pm-device
branch
from
01d1193 to
08b1161
Compare
gmarull
approved these changes
Feb 14, 2025
masz-nordic
approved these changes
Feb 14, 2025
anangl
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PM device runtime support to nRF SAADC device driver.