Bluetooth: Host: More bsim refactoring #85319
Open
+865
−2,385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
aescolar,
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
Commit does the following changes: * Use functionality from the `babbelkit` library for common functions related to flags, test progression (failing, passing etc.) and synchronization between two devices. Locally defined equivalents are removed. * Removes the files containing only functionality that is provided by the `babblekit` library. * Remove the `test_pre_init_f` and `test_tick_f` functions (commonly implemented as `test_init` and `test_tick`) from the modified tests. These functions are not needed as they were only used to fail the test if a device didn't complete the test within a certain time frame. This is already handled by the `sim_length` argument used in the test scripts. Signed-off-by: Håvard Reierstad <[email protected]>
HaavardRei
force-pushed
the
host_bsim_refactor
branch
from
aece18e to
2767fd4
Compare
alwa-nordic
approved these changes
Feb 6, 2025
|
|
aescolar
reviewed
Feb 6, 2025
|
|
||
| #include <zephyr/logging/log.h> | ||
| LOG_MODULE_REGISTER(bt_bsim_mtu_update, LOG_LEVEL_DBG); | ||
|
|
||
| #define PERIPHERAL_NOTIFY_TIME 10 |
There was a problem hiding this comment.
Just a suggestion
Suggested change
| #define PERIPHERAL_NOTIFY_TIME 10 | |
| #define PERIPHERAL_NOTIFY_TIME 10 /* seconds */ |
| @@ -22,6 +31,14 @@ struct adv_set_data_t { | |||
| static uint8_t adv_index; | |||
| static struct adv_set_data_t adv_set_data[CONFIG_BT_EXT_ADV_MAX_ADV_SET]; | |||
|
|
|||
| static void print_address(bt_addr_le_t *addr) | |||
There was a problem hiding this comment.
It seems a bit silly to copy this around.. don't you want to add it to the babblekit library?
(or leave it in that bs_bt_utils.c as a more evident thing somebody will be inclined to clean later :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit does the following changes:
babbelkitlibrary for common functions related to flags, test progression (failing, passing etc.) and synchronization between two devices. Locally defined equivalents are removed.babblekitlibrary.test_pre_init_fandtest_tick_ffunctions (commonly implemented astest_initandtest_tick) from the modified tests. These functions are not needed as they were only used to fail the test if a device didn't complete the test within a certain time frame. This is already handled by thesim_lengthargument used in the test scripts.