scripts: footprint: size_report: Add JSON prefix support #84915
+23
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nordicjm
commented
Jan 30, 2025
nordicjm
commented
Adds support for prefixing JSON output files for different targets Signed-off-by: Jamie McCrae <[email protected]>
Adds support for prefixing files with the target of bl2 or tfm Signed-off-by: Jamie McCrae <[email protected]>
tejlmand
requested changes
Feb 5, 2025
| -o ${CMAKE_BINARY_DIR} | ||
| ${workspace_arg} | ||
| -d ${report_depth} | ||
| --prefix bl2 |
There was a problem hiding this comment.
size_report already supports writing to an alternative file using --json <file>, so why not use what we have instead of introducing yet another argument ?
Suggested change
| --prefix bl2 | |
| --json bl2_${report}.json |
tejlmand
reviewed
Feb 5, 2025
| @@ -40,6 +40,7 @@ if (CONFIG_BUILD_WITH_TFM) | |||
| -o ${CMAKE_BINARY_DIR} | |||
| ${workspace_arg} | |||
| -d ${report_depth} | |||
| --prefix tfm | |||
There was a problem hiding this comment.
size_report already supports writing to an alternative file using --json <file>, so why not use what we have instead of introducing yet another argument ?
Suggested change
| --prefix tfm | |
| --json tfm_${report}.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.