adc: esp32c3: fix overlay and adc driver calib setup #84653
Merged
+13
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
sylvioalves
force-pushed
the
bugfix/adc_esp32c3
branch
from
3578abe to
1e92bfa
Compare
sylvioalves
changed the title
sylvioalves
force-pushed
the
bugfix/adc_esp32c3
branch
2 times, most recently
from
3a03a6e to
dbbb983
Compare
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
anangl,
kartben,
LucasTambor,
marekmatej,
nashif,
raffarost,
uLipe and
wmrsouza
wmrsouza
previously approved these changes
Jan 28, 2025
|
@sylvioalves i believe this overlaps with the work in #84380 |
It does, but this is fixing Build is currently failing for esp32c3 ADC. |
raffarost
previously approved these changes
Jan 28, 2025
uLipe
previously approved these changes
Jan 28, 2025
anangl
previously approved these changes
Jan 28, 2025
marekmatej
previously approved these changes
Jan 28, 2025
sylvioalves
dismissed stale reviews from marekmatej, anangl, uLipe, raffarost, and wmrsouza
via
1660efb
sylvioalves
force-pushed
the
bugfix/adc_esp32c3
branch
from
dbbb983 to
1660efb
Compare
wmrsouza
approved these changes
Jan 30, 2025
kartben
requested changes
Jan 30, 2025
There was a problem hiding this comment.
no #123456 references in commit messages please :)
https://docs.zephyrproject.org/latest/contribute/guidelines.html#:~:text=Do%20not%20include%20GitHub%20references%20in%20the%20commit%20message%20directly%2C%20as%20it%20can%20lose%20meaning%20in%20case%20the%20repository%20is%20forked%2C%20for%20example.
Remove ADC2 support (identified as adc1 entry) for additional ESP32-C3 based board targets. Other boards have those instances already deleted. Signed-off-by: Sylvio Alves <[email protected]>
In case channel_setup is called with a new attenuation config, make sure previous calibration scheme is deleted properly. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
bugfix/adc_esp32c3
branch
from
1660efb to
34c2ce0
Compare
kartben
approved these changes
Jan 30, 2025
raffarost
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #84254, remove ADC2 support
for this remaining ESP32C3 based board targets.
This also changes ADC driver to delete previous calib curve in case channel_setup is run again.