[v3.7 branch] shell: fix unsafe API calls and add configurable autoflush behavior #84589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new Kconfig option `SHELL_PRINTF_AUTOFLUSH` to allow configuring the autoflush behavior of shell printing functions. Updated `Z_SHELL_FPRINTF_DEFINE` to use the `CONFIG_SHELL_PRINTF_AUTOFLUSH` setting instead of hardcoding the autoflush behavior to `true`. Signed-off-by: Jakub Rzeszutko <[email protected]> (cherry picked from commit 8991b95)
pdgendt
reviewed
Jan 27, 2025
|
The backport label is to automate it, no need to add this here. |
pdgendt
added
Backport
Fixes an issue where the shell API could block indefinitely when called from threads other than the shell's processing thread, especially when the transport (e.g. USB CDC ACM) was unavailable or inactive. Replaced `k_mutex_lock` calls with an indefinite timeout (`K_FOREVER`) by using a fixed timeout (`K_MSEC(SHELL_TX_MTX_TIMEOUT_MS)`) in shell API functions to prevent indefinite blocking. Signed-off-by: Jakub Rzeszutko <[email protected]> (cherry picked from commit b0a0feb)
jakub-uC
force-pushed
the
backport-84290-to-v3.7-branch
branch
from
7685453 to
2145bb7
Compare
|
done |
pdgendt
approved these changes
Jan 27, 2025
henrikbrixandersen
approved these changes
Jan 27, 2025
nashif
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Please use a title that describes the change, not numbers and branches, also include a body in the PR with more details, beside the bug being fixed.
Nobody knows what 84290 is and similarly, nobody knows what #84439 fixes by just looking at numbers.
|
@nashif done |
|
should be fixing #84274? |
|
Yes, fixed it. |
nashif
changed the title
nashif
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new Kconfig option
SHELL_PRINTF_AUTOFLUSHto allowconfiguring the autoflush behavior of shell printing functions.
Updated
Z_SHELL_FPRINTF_DEFINEto use theCONFIG_SHELL_PRINTF_AUTOFLUSHsetting instead of hardcodingthe autoflush behavior to
true.Fixes an issue where the shell API could block indefinitely when called
from threads other than the shell's processing thread, especially when
the transport (e.g. USB CDC ACM) was unavailable or inactive.
Replaced
k_mutex_lockcalls with an indefinite timeout (K_FOREVER)by using a fixed timeout (
K_MSEC(SHELL_TX_MTX_TIMEOUT_MS)) in shellAPI functions to prevent indefinite blocking.
Fixes #84274