[Backport v3.6-branch] devicetree.h: switch to DT_IRQ_INTC_BY_IDX for L2 and L3 INTID encodings #69834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `DT_IRQ_INTC()` to fetch the interrupt controller associated with a node works well for nodes which consume interrupts from a single aggregator. However, when specifying multiple (and different) interrupt aggregators via the `interrupts-extended` property, the L2 and L3 interrupts will no longer be encoded properly. This is because `DT_IRQ_INTC(node_id)` uses `DT_IRQ_INTC_BY_IDX(node_id, 0)` so all the interrupts will use the first aggregator as their parent. To fix this, switch from using `DT_IRQ_INTC()` to `DT_IRQ_INTC_BY_IDX()`. Signed-off-by: Laurentiu Mihalcea <[email protected]> (cherry picked from commit 3799e0f)
Add some assert statements meant to check if L2 interrupts are encoded right when dealing with nodes that consume interrupts from multiple aggregators. For this to work, also add another interrupt controller node which extends a different L1 interrupt from `test_intc`. Signed-off-by: Laurentiu Mihalcea <[email protected]> (cherry picked from commit 8fec5f3)
zephyrbot
added
Backport
bjarki-andreasen
approved these changes
Mar 6, 2024
ycsin
approved these changes
Mar 6, 2024
iuliana-prodan
approved these changes
Mar 6, 2024
dbaluta
approved these changes
Mar 6, 2024
henrikbrixandersen
approved these changes
Mar 6, 2024
MaureenHelm
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8fec5f3~2..8fec5f3 from #68784.
Fixes #69820