Skip to content

picolib: Add stdc++ noexcept variant #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

picolib: Add stdc++ noexcept variant #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[submodule "crosstool-ng"]
path = crosstool-ng
url = https://github.com/zephyrproject-rtos/crosstool-ng.git
url = https://github.com/adigie/crosstool-ng.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this use the same picolibcpp.specs file and just replace -lstdc++ with -lstdc++-noexcept? Do we need different header paths or something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about doing something similar to Newlib nano, but it would probably be easier to keep the same specs file for all configurations.

I made a change in Zephyr to link proper variant: zephyrproject-rtos/zephyr/pull/85945
Is this what you had in mind?

[submodule "binutils"]
path = binutils
url = https://github.com/zephyrproject-rtos/binutils-gdb.git
Expand Down
1 change: 1 addition & 0 deletions cmake/zephyr/generic.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ set(CROSS_COMPILE ${one_toolchain_root}/${CROSS_COMPILE_TARGET}/bin/${CROSS_COMP
set(SYSROOT_DIR ${one_toolchain_root}/${SYSROOT_TARGET}/${SYSROOT_TARGET})
set(TOOLCHAIN_HAS_NEWLIB ON CACHE BOOL "True if toolchain supports newlib")
set(TOOLCHAIN_HAS_PICOLIBC ON CACHE BOOL "True if toolchain supports picolibc")
set(TOOLCHAIN_HAS_PICOLIBC_NOEXCEPT ON CACHE BOOL "True if toolchain supports picolibc variant with exceptions disabled")
2 changes: 1 addition & 1 deletion crosstool-ng
Open in desktop
Submodule crosstool-ng updated 3 files
+10 −0 config/comp_libs/picolibc.in
+1 −0 samples/arm-picolibc-eabi/crosstool.config
+29 −2 scripts/build/companion_libs/340-picolibc.sh
Loading