sonarlint suggestions

zephir-lang · Nov 27, 2023 · 9a9adbd · 9a9adbd
1 parent 331b62c
commit 9a9adbd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/src/Class/Method/Method.php b/src/Class/Method/Method.php
@@ -1841,16 +1841,19 @@ public function compile(CompilationContext $compilationContext): void
              */
             $lastType = $this->statements->getLastStatementType();
 
-            if ('return' !== $lastType && 'throw' !== $lastType && !$this->hasChildReturnStatementType($statement)) {
-                /**
-                 * If a method has return-type hints we need to ensure the last statement is a 'return' statement
-                 */
-                if ($this->hasReturnTypes()) {
-                    throw new CompilerException(
-                        'Reached end of the method without returning a valid type specified in the return-type hints',
-                        $this->expression['return-type']
-                    );
-                }
+            /**
+             * If a method has return-type hints we need to ensure the last
+             * statement is a 'return' statement
+             */
+            if (
+                'return' !== $lastType &&
+                'throw' !== $lastType && !$this->hasChildReturnStatementType($statement) &&
+                $this->hasReturnTypes()
+            ) {
+                throw new CompilerException(
+                    'Reached end of the method without returning a valid type specified in the return-type hints',
+                    $this->expression['return-type']
+                );
             }
         }
 

diff --git a/src/Statements/ReturnStatement.php b/src/Statements/ReturnStatement.php
@@ -13,6 +13,7 @@
 
 namespace Zephir\Statements;
 
+use ReflectionException;
 use Zephir\CompilationContext;
 use Zephir\Exception;
 use Zephir\Exception\CompilerException;
@@ -26,11 +27,13 @@
  */
 final class ReturnStatement extends StatementAbstract
 {
+    private const RETURN_RETURN = 'return;';
+
     /**
      * @param CompilationContext $compilationContext
      *
      * @throws Exception
-     * @throws \ReflectionException
+     * @throws ReflectionException
      */
     public function compile(CompilationContext $compilationContext): void
     {
@@ -222,7 +225,7 @@ public function compile(CompilationContext $compilationContext): void
                     if ('return_value' != $resolvedExpr->getCode()) {
                         $codePrinter->output('RETURN_CTOR('.$resolvedExpr->getCode().');');
                     } else {
-                        $codePrinter->output('return;');
+                        $codePrinter->output(self::RETURN_RETURN);
                     }
                     break;
 
@@ -300,10 +303,10 @@ public function compile(CompilationContext $compilationContext): void
                                                 $compilationContext->backend->getVariableCode($symbolVariable)
                                             )
                                         );
-                                        $codePrinter->output('return;');
+                                        $codePrinter->output(self::RETURN_RETURN);
                                     }
                                 } else {
-                                    $codePrinter->output('return;');
+                                    $codePrinter->output(self::RETURN_RETURN);
                                 }
                             }
                             if ($symbolVariable->isTemporal()) {