setting handshake timeout for gorilla websocket package which should …

…solve the issue of connections dropping

cmd/cloudshell/config.go

@@ -15,7 +15,7 @@ var conf = config.Map{
 		Shorthand: "H",
 	},
 	"arguments": &config.StringSlice{
-		Default:   []string{"-l"},
+		Default:   []string{},
 		Usage:     "comma-delimited list of arguments that should be passed to the terminal command",
 		Shorthand: "r",
 	},

pkg/xtermjs/handler_websocket.go

@@ -134,7 +134,7 @@ func GetHandler(opts HandlerOpts) func(http.ResponseWriter, *http.Request) {
 				messageType, reader, err := connection.NextReader()
 				if err != nil {
 					if !connectionClosed {
-						clog.Warn("failed to get next reader: %s", err)
+						clog.Warnf("failed to get next reader: %s", err)
 					}
 					return
 				}

pkg/xtermjs/utils.go

@@ -26,7 +26,8 @@ func getConnectionUpgrader(
 			logger.Warnf("failed to find '%s' in the list of allowed hostnames ('%s')", requesterHostname)
 			return false
 		},
-		ReadBufferSize:  maxBufferSizeBytes,
-		WriteBufferSize: maxBufferSizeBytes,
+		HandshakeTimeout: 0,
+		ReadBufferSize:   maxBufferSizeBytes,
+		WriteBufferSize:  maxBufferSizeBytes,
 	}
 }