Add daytona orchestrator #3361
Add daytona orchestrator #3361
Conversation
github-actions
bot
added
internal
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
| Returns: | ||
| The flavor logo. | ||
| """ | ||
| return "https://public-flavor-logos.s3.eu-central-1.amazonaws.com/orchestrator/daytona.png" |
| # permissions and limitations under the License. | ||
| """Initialization of the Daytona orchestrators package.""" | ||
|
|
||
| from .daytona_orchestrator import DaytonaOrchestrator |
| """ | ||
| return DaytonaOrchestratorSettings | ||
|
|
||
| @property |
| ] | ||
| ): | ||
| workspace_params.resources = WorkspaceResources( | ||
| cpu=settings.cpu, |
There was a problem hiding this comment.
Should use resource settings
| ) | ||
|
|
||
| # Execute custom commands if any | ||
| settings = cast(DaytonaOrchestratorSettings, self.config) |
There was a problem hiding this comment.
Why does this use the config, this should use settings?
| name=orchestrator_run_name, | ||
| image=settings.image, | ||
| os_user=settings.os_user, | ||
| env_vars=settings.env_vars, |
There was a problem hiding this comment.
Why do we pass some env vars here, and then have some ugly logic that manually export A=B stuff later?
| env_vars = environment.copy() | ||
| env_vars[ENV_ZENML_DAYTONA_RUN_ID] = orchestrator_run_name | ||
| env_vars[ENV_ZENML_CUSTOM_SOURCE_ROOT] = ( | ||
| DAYTONA_ZENML_DEFAULT_CUSTOM_REPOSITORY_PATH |
There was a problem hiding this comment.
I'm not sure how this is supposed to work, I don't think anything exists at that path?
| f"mkdir -p {DAYTONA_ZENML_DEFAULT_CUSTOM_REPOSITORY_PATH}", | ||
| cwd="/home/daytona", | ||
| ) | ||
|
|
There was a problem hiding this comment.
Neither ZenML nor the stack/pipeline requirements get installed
| logger = get_logger(__name__) | ||
|
|
||
|
|
||
| def parse_args() -> argparse.Namespace: |
There was a problem hiding this comment.
I don't understand why this file is necessary
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| # or implied. See the License for the specific language governing | ||
| # permissions and limitations under the License. | ||
| """Entrypoint configuration for the Daytona orchestrator.""" |
There was a problem hiding this comment.
I don't understand why this file is necessary
|
@schustmi sorry just wanted to let the tests run should have done a draft instead |
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes