-
Notifications
You must be signed in to change notification settings - Fork 59
Add sandbox dockerfile generator script #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One immediate comment (sorry if there's some context I'm missing here): do we not also want to automate this in the sense that it runs in the CI (i.e. on merging things into |
…add typings + docs
… set environment variables directly
@strickvl I've updated the script to use I've also renamed the base docker image to |
That naming convention feels a bit weird. So you're using the tag as the name instead of the actual image name? How would we support multiple versions of a project? Just when we update / upgrade we no longer offer a supported version? |
@strickvl hmm I was thinking we'd have 1 version at most for each project, but yes the naming convention does feel weird. will revert to |
Practically we'd probably only support one version. But I think in practice, some people might be playing around with one version etc and then if we 'upgrade' that version (as we have done with our projects many times) then suddenly that person's code / run behaviour changes etc.. I think that's probably undesirable. |
@strickvl Gotcha, though adding custom tags to the build/push docker images workflow might get tricky. When we need to preserve the original image while pushing a new tag, we'd either need to manually trigger the workflow with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added to the naming discussion above. overall looks good though
I've renamed the base image to
The generated Dockerfiles will be named |
This PR adds:
zenmldocker
on DockerHub when changes are made to project directories.Changes:
scripts
directoryDockerfile.codespace
for oncoclear and omni-reader as examplesHow the workflow works:
path-ignore
pattern to exclude non-project files and directoriesDockerfile.codespace
:generate_codespace_dockerfile.py
scriptDockerfile.codespace
: