Upgrade PHPUnit to v11 #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html
NattyNarwhal
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request updates PHPUnit from
^8.2to^11.0. It adds missing: voidreturn type declarations for test methods and updates the visibility ofsetUp()methods toprotectedin line with PHPUnit best practices. The upgrade from version 8 to version 10 was done using Laravel Shift. The upgrade to PHPUnit version 11 was done manually, with the only necessary change being renaming the fileToolkitServiceParameterTestto match the class nameProgramParameterTestto resolve a deprecation warning.Changes:
phpunit/phpunitto^11.0incomposer.json.: voidreturn type hints to test methods.setUp()method visibility frompublictoprotected.ToolkitServiceParameterTest.phptoProgramParameterTest.phpfor consistency with class name of the file.