Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support by adding Odbc\Connection handling #216

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jonkerw85
Copy link
Contributor

Pull Request Description:
This PR fixes a few missed spots in the PHP 8.4 compatibility update by properly supporting Odbc\Connection.

Changes:

  • Updated function docblock to include Odbc\Connection.
  • Fixed type-checking logic to recognize Odbc\Connection.
  • Adjusted ODBC transport handling to ensure compatibility.

- Added support for running unit tests using SQLite by introducing `mockDb2UsingSqlite` config option.
- Refactored DSN handling with a `buildDsn` method for better maintainability.
- Fixed issues with ODBC connection handling, improving compatibility with PHP 8.4.
- Updated tests to dynamically determine the DSN based on the configuration.

This makes it easier to run tests without an IBM i system and allows for automated testing across multiple PHP versions.
Updated the `$databaseNameOrResource` parameter to support `Odbc\Connection`, expanding compatibility for database connections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant