Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle kinesis large values #1428

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rotemseekingalpha
Copy link

add producer_max_value_size
remove largest value (> producer_max_value_size) recursively from RowMap.data

@osheroff
Copy link
Collaborator

intersting approach. I wouldn't want this on by default, but I could see it as an option; cut out large blobs but get the important bits in by default.

For me to merge this PR I think:

  • there'd need to be tests. This probably means extracting the code into a module somewhere.
  • there'd need to be configuration to turn it on
  • it should work for kafka too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants