Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Leap highlight are out of date #195

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

GCBallesteros
Copy link
Contributor

Support for leap is broken. At some leap must have changed it's highlight group names breaking the integration. They are currently:

  • LeapMatch
  • LeapLabel
  • LeapBackdrop

This PR does two things:

  1. Update the highlight group names
  2. Modify the used colors to increase the usability of leap and bringing it more to line

The images below show screenshots for zenbones dark & light when Leap is active
image
image

Rationale for color change

Previously the labels used the same colors as IncSearch (bold white foreground over magenta background):
image.

In my opinion this is not high contrast enough for how leap (or any other jump plugin) is used. In this kind of plugins labels are visible in practice for around 200 or 300 ms at most so you really need them to stand out. On the static picture the colors might look too strong but since they are only on the screen for a fraction of a second at a time they don't destroy the zenbones experience.

The new colors respect the previous hues but change the saturation and lightness. It also makes use of the LeapBackdrop group to further enhance readability.

@mcchrish
Copy link
Collaborator

Makes sense to me! Thanks a lot.

@mcchrish mcchrish merged commit b433225 into zenbones-theme:main Aug 23, 2024
5 checks passed
@GCBallesteros
Copy link
Contributor Author

Thanks to you for the great themes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants