fix: Leap highlight are out of date #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for leap is broken. At some leap must have changed it's highlight group names breaking the integration. They are currently:
LeapMatch
LeapLabel
LeapBackdrop
This PR does two things:
The images below show screenshots for zenbones dark & light when Leap is active
Rationale for color change
Previously the labels used the same colors as
IncSearch
(bold white foreground over magenta background):.
In my opinion this is not high contrast enough for how leap (or any other jump plugin) is used. In this kind of plugins labels are visible in practice for around 200 or 300 ms at most so you really need them to stand out. On the static picture the colors might look too strong but since they are only on the screen for a fraction of a second at a time they don't destroy the zenbones experience.
The new colors respect the previous hues but change the saturation and lightness. It also makes use of the
LeapBackdrop
group to further enhance readability.