Skip to content

feat: show system notification once download is complete, canceled or failed #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Clstialdev
Copy link

@Clstialdev Clstialdev commented May 11, 2025

Added desktop notifications for download events.
The browser now shows a system notification when a download:

  • completes successfully

  • is canceled

  • fails due to error

Each notification:

  • Uses a localized title and message (document.l10n.formatValue)

  • Falls back to plain strings if localization fails

  • Includes the downloaded file's path

  • Uses the standard download.svg icon

  • Can be toggled via the zen.downloads.download-notifications preference

This enhancement improves user feedback and aligns with modern UX expectations for background downloads.

image

Translations (l10n): zen-browser/l10n-packs#153

@Clstialdev Clstialdev requested a review from mauro-balades as a code owner May 11, 2025 14:52
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature labels May 11, 2025
@mauro-balades
Copy link
Member

How does it look?

@Clstialdev
Copy link
Author

How does it look?

It uses the system notifications (OS notifications), on Linux it looks like this:
image

I also made this PR to add translation: zen-browser/l10n-packs#153

@mauro-balades
Copy link
Member

Oh, sorry! The images didnt load.

@Clstialdev
Copy link
Author

Oh, sorry! The images didnt load.

@mauro-balades I added the images after your comment, do let me know if you want any changes done! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants