Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package mantainance #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Package mantainance #35

wants to merge 1 commit into from

Conversation

math-a3k
Copy link

@math-a3k math-a3k commented Feb 1, 2024

Hi! I needed to update tradero to Django 5 and I am using this package which is the one that I have been using in my previous projects.

First I lift the Django version's upper limit to make the upgrade possible.

This is the only change needed to allow Django 5.

Then I decided to do some package maintenance and update Bootstrap, the dependencies, and the CI accordingly.

Updating the dependencies leads to requiring Python>=3.8 - which may be undesired for providing compatibility for legacy applications.

I can undo the updated requirements and CI (leaving only the update of Bootstrap and removing the Django upper limit) if you deem it proper, otherwise this will make the package be checked to the latest stack.

Please let me know and I'll adjust the PR accordingly.

This should fix #33

  • Update to Bootstrap 5.3.2

  • Update pyproject.toml

  • Lift django version upper limit

  • Require Python>=3.8

  • Update classifiers for supported Python and Django versions

  • Update ci.yml

  • Use new supported Python versions

  • Update poetry.lock

  • Update tests/test_templatetags.py

    • Skip failing test in all Django versions
  • Update tox.ini

    • Update supported Python versions
    • Update supported Django versions
  • Bump Version

  • Update CHANGELOG.md

  • Update README.md

- Update to Bootstrap 5.3.2

- Update pyproject.toml
 - Lift django version upper limit
 - Require Python>=3.8
 - Update classifiers for supported Python and Django versions

- Update ci.yml
 - Use new supported Python versions

- Update poetry.lock

- Update tests/test_templatetags.py
  - Skip failing test in all Django versions

- Update tox.ini
  - Update supported Python versions
  - Update supported Django versions

- Bump Version

- Update CHANGELOG.md

- UUpdate README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pypi release 1.0.11 does not support Django 5.0
1 participant