Clean up configure.py, move common logic to tools/project.py #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encounter
force-pushed
the
configure-cleanup
branch
3 times, most recently
from
90b2765
to
535d669
Compare
encounter
force-pushed
the
configure-cleanup
branch
from
535d669
to
9c6f228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to move all project-agnostic generator logic into
tools/project.py, leaving an (ideally) much more focused and readableconfigure.py.configure.pycan be modified to suit a specific project's needs, while maintaining compatibility with future decomp-toolkit updates by sharing the core generator logic intools/project.py.Feedback appreciated!