Skip to content

Commit

Permalink
Document an obscure bug in J3DGDSetTexCoordScale2
Browse files Browse the repository at this point in the history
  • Loading branch information
LagoLunatic committed Jun 25, 2024
1 parent f9d40eb commit 93a883f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/JSystem/J3DGraphBase/J3DGD.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,9 @@ void J3DGDSetTexCoordGen(GXTexGenType type, GXTexGenSrc src) {
void J3DGDSetTexCoordScale2(GXTexCoordID id, u16 scaleS, u8 biasS, u8 wrapS, u16 scaleT, u8 biasT, u8 wrapT) {
GDOverflowCheck(15);
J3DGDWriteBPCmd(0xFE03FFFF);
// Bug: When id is GX_TEXCOORD_NULL (0xFF), the calculation below winds up producing the wrong
// BP register ID. Instead of a SU_SSIZE and SU_TSIZE register, it effectively negatively
// overflows to the previous registers: RAS1_TREF6 and RAS1_TREF7, potentially corrupting them.
J3DGDWriteBPCmd((scaleS - 1) | (biasS << 16) | (wrapS << 17) | (0x30 + id * 2) << 24);
J3DGDWriteBPCmd((scaleT - 1) | (biasT << 16) | (wrapT << 17) | (0x31 + id * 2) << 24);
}
Expand Down

0 comments on commit 93a883f

Please sign in to comment.