[Audio 7/?] Extract sequences to assembly #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MNGoldenEagle <[email protected]> Co-authored-by: zelda2774 <[email protected]>
hensldm
added
Audio
Needs-second-approval
hensldm
approved these changes
Sep 3, 2024
AngheloAlf
approved these changes
Sep 4, 2024
AngheloAlf
added
Merge-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the audio extraction tools to allow extracting all sequence files besides the "handwritten" sequences 0 and 1 to a textual assembly format. Names for the sequence instructions are lifted from prior work (SM64 Decomp, OoT zeldaret/oot#1236 and OoT zeldaret/oot#1509) and should not be considered as final, see the table in
disassemble_sequence.pyfor the full set. The remaining sequence files and the build process for them will come next.