Clang-Format 14 #1321
Merged
Clang-Format 14 #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngheloAlf
added
Tooling
Needs-second-approval
|
Adding the |
|
Fwiw, I believe all agents have been updated to have both |
AngheloAlf
approved these changes
Jul 11, 2023
jpburnett
approved these changes
Jul 14, 2023
|
Just want to mention, I had forgotten to update the dockerfile as well as other documentation so went ahead and did that. |
engineer124
approved these changes
Jul 17, 2023
AngheloAlf
reviewed
Jul 18, 2023
docs/BUILDING_MACOS.md
Outdated
|
|
||
| You can install them with the following commands: | ||
|
|
||
| ```bash | ||
| brew update | ||
| brew install coreutils make python3 libpng bash clang-format@11 | ||
| brew install coreutils make python3 libpng bash clang-format@14 |
There was a problem hiding this comment.
Just noticed a problem, the homebrew page for clang-format 14 doesn't seem to exist
https://formulae.brew.sh/formula/clang-format@14
As a reference this is version 11: https://formulae.brew.sh/formula/clang-format@11
AngheloAlf
added
Merge-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to zeldaret/oot#1517
Note I added some
(void*)casts to the overlayoverlayEntrycomputation. This is more likely how they will end up being anyways from #1266 . The format in bigslime is weird, but seems worth it to upgrade anyways.