Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake variables for shared/static library suffixes #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Sep 6, 2024

I noticed this while adding Redis support to the storage framework branch. We can't hardcode .so/.a for all platforms because on Windows it's .dll/.lib and on macOS shared libraries are .dylib. Use CMake variables to make these checks platform-independent.

@timwoj timwoj force-pushed the topic/timw/use-cmake-variables-for-library-name-suffixes branch from af9cc63 to 1efc03b Compare September 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant